[PATCH] Re: CEA mode 61 wrong in EDID parser

[Adam Jackson]

On Mon, 2010-01-04 at 14:39 +0800, ykzhao wrote:
> On Sun, 2010-01-03 at 14:42 +0800, Anssi Hannula wrote:
> > Hi!
> > 
> > The commit fc2ec95664d55f45f77f1ebb039a7c17a1fcdaa3 in xserver added the CEA 
> > modes in xf86EdidModes.c, however it seems mode 61 is wrong:
> > > +    { MODEPREFIX,    74250, 3700, 3740, 1430, 3960, 0,  720,  725,  730, 
> > > 750, 0, V_PHSYNC | V_PVSYNC, MODESUFFIX }, /* VIC 61: 1280x720 at 25Hz */
> > 
> > At least the horizontal values are invalid. I don't have the CEA spec so I 
> > don't know the what the correct values are.
> > 
> You are right.
> Thanks for pointing out this issue.
> 
> It seems that correct value is :
> { MODEFIX, 74250, 1280, 3700, 3740, 3960, 0, 720, 725, 730, 750}.
> 
> 
> >From 6807266ae606e229a64902611c1a4f8ce267414f Mon Sep 17 00:00:00 2001
> From: Zhao Yakui <yakui.zhao at intel.com>
> Date: Mon, 4 Jan 2010 14:36:05 +0800
> Subject: [PATCH] EDID: fix the incorrect mode definition for VIC61 in
> CEA
> 
> Fix the incorrect mode definition for VIC61 in CEA.
> 
> Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>
> Signed-off-by: Anssi Hannula <anssi.hannula at iki.fi>

Reviewed-by: Adam Jackson <ajax at redhat.com>

- ajax

> ---
>  hw/xfree86/modes/xf86EdidModes.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/xfree86/modes/xf86EdidModes.c
> b/hw/xfree86/modes/xf86EdidModes.c
> index ec65408..999bf80 100644
> --- a/hw/xfree86/modes/xf86EdidModes.c
> +++ b/hw/xfree86/modes/xf86EdidModes.c
> @@ -956,7 +956,7 @@ static const DisplayModeRec
> CEAVideoModes[CEA_VIDEO_MODES_NUM] = {
>      { MODEPREFIX,   108000, 1440, 1478, 1602, 1716, 0,  480,  488,
> 494,  525, 0, V_NHSYNC | V_NVSYNC | V_INTERLACE, MODESUFFIX },/* VIC
> 58:1440x480i at 240 */
>      { MODEPREFIX,   108000, 1440, 1478, 1602, 1716, 0,  480,  488,
> 494,  525, 0, V_NHSYNC | V_NVSYNC | V_INTERLACE, MODESUFFIX },/* VIC
> 59:1440x480i at 240 */
>      { MODEPREFIX,    59400, 1280, 3040, 3080, 3300, 0,  720,  725,
> 730,  750, 0, V_PHSYNC | V_PVSYNC, MODESUFFIX }, /* VIC 60:
> 1280x720 at 24Hz */
> -    { MODEPREFIX,    74250, 3700, 3740, 1430, 3960, 0,  720,  725,
> 730,  750, 0, V_PHSYNC | V_PVSYNC, MODESUFFIX }, /* VIC 61:
> 1280x720 at 25Hz */
> +    { MODEPREFIX,    74250, 1280, 3700, 3740, 3960, 0,  720,  725,
> 730,  750, 0, V_PHSYNC | V_PVSYNC, MODESUFFIX }, /* VIC 61:
> 1280x720 at 25Hz */
>      { MODEPREFIX,    74250, 1280, 3040, 3080, 3300, 0,  720,  725,
> 730,  750, 0, V_PHSYNC | V_PVSYNC, MODESUFFIX }, /* VIC 62:
> 1280x720 at 30Hz */
>      { MODEPREFIX,   297000, 1920, 2008, 2052, 2200, 0, 1080, 1084,
> 1089, 1125, 0, V_PHSYNC | V_PVSYNC, MODESUFFIX }, /* VIC 63:
> 1920x1080 at 120Hz */
>      { MODEPREFIX,   297000, 1920, 2448, 2492, 2640, 0, 1080, 1084,
> 1094, 1125, 0, V_PHSYNC | V_PVSYNC, MODESUFFIX }, /* VIC
> 64:1920x1080 at 100Hz */


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101005/1d58d7af/attachment.pgp>