[PATCH ati] Remove reference to pixmapPrivate.

Michel Dänzer michel at daenzer.net
Fri Oct 1 10:23:05 PDT 2010


On Fre, 2010-10-01 at 18:57 +0200, Julien Cristau wrote: 
> On Fri, Oct  1, 2010 at 18:29:54 +0200, Michel Dänzer wrote:
> 
> > On Fre, 2010-10-01 at 18:27 +0200, Julien Cristau wrote: 
> > > #if ABI_VIDEODRV_VERSION < SET_ABI_VERSION(9, 0)
> > > old code
> > > #else
> > > new code
> > > #endif
> > 
> > That would work perfectly, if the ABI was bumped by every change which
> > breaks the ABI...
> > 
> It'll work for this specific bump.

Not when building against xserver commits between
5c6a2f93ebc16a78093782b442306de23ae94e78 and
1a9022d3289ff74043112808cc8aa315fd9c40e8 . Certainly better than merely
checking the server version though.

> Or you could do something like
> AC_CHECK_MEMBERS([ScrnInfoRec.pixmapPrivate],[],[],[#include <xf86str.h>])
> in configure.ac, and check HAVE_SCRNINFOREC_PIXMAPPRIVATE.

Right, though that will require manually re-running configure when
crossing this ABI break.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer


More information about the xorg-devel mailing list