[PATCH v3 0/2] xserver: Client ID tracking

Rami Ylimäki rami.ylimaki at vincit.fi
Fri Oct 1 08:14:43 PDT 2010


Fixes based on comments of various reviewers.

v2
--
Mark Kettenis:
    move /proc specific code into os
    treat pid -1 as error instead of 0
Tiago Vignatti:
    preserve copyrights
    amend authorship
    add description of the framework
    use doxygen style
    rename cmd -> cmdline in ClientIdsPrivateRec
    compile only if XRES or XSELINUX is enabled

v3
--
Fernando Carrijo:
    don't use -o or -a with "test" shell command
Tiago Vignatti:
    use doxygen @file directive
    move pid_t related functions into os
    remove unnecessary header inclusions
    let client ID tracking be disabled with --disable-clientids
    create dummy stubs for initialization functions if disabled
    don't make XSELinux depend on client ID tracking
    squash copyrights into main commit
    don't add copyright for restructuring of minor code segments

Review comments not respected:
    don't install client ID tracking headers
Rationale:
    As soon as client ID tracking is incorporated into X server, it
    will be used from debugging code of at least one video driver.

Rami Ylimäki (2):
  dix: Add facilities for client ID tracking.
  Xext: Use general OS functions to determine client command string in
    SELinux.

 Xext/xselinux_hooks.c        |   22 +--
 configure.ac                 |   15 ++-
 dix/Makefile.am              |    1 +
 dix/client.c                 |  345 ++++++++++++++++++++++++++++++++++++++++++
 dix/main.c                   |    3 +
 hw/xfree86/loader/sdksyms.sh |    1 +
 include/Makefile.am          |    1 +
 include/client.h             |   60 ++++++++
 include/dix-config.h.in      |    3 +
 include/os.h                 |    3 +
 os/access.c                  |   76 +++++++++
 11 files changed, 512 insertions(+), 18 deletions(-)
 create mode 100644 dix/client.c
 create mode 100644 include/client.h



More information about the xorg-devel mailing list