[PATCH] dix: do not use bit-wise operators on the boolean result of BitIsOn

Peter Hutterer peter.hutterer at who-t.net
Mon Nov 29 14:02:06 PST 2010


On Mon, Nov 29, 2010 at 06:27:34PM +0100, Ferry Huberts wrote:
> On 11/29/2010 05:47 PM, Julien Cristau wrote:
> > On Mon, Nov 29, 2010 at 17:09:31 +0100, Ferry Huberts wrote:
> >
> >> From: Ferry Huberts <ferry.huberts at pelagic.nl>
> >>
> >> Signed-off-by: Ferry Huberts <ferry.huberts at pelagic.nl>
> >> ---
> >>  dix/getevents.c |   12 ++++++------
> >>  1 files changed, 6 insertions(+), 6 deletions(-)
> >>
> > I'm missing the "why" for this change.  It looks like a no-op to me...
> >
> > Cheers,
> > Julien
> correctness.
> 
> I discussed this with Peter off-list and he invited me to send a patch.
> Hence this patch :-)

right, do me a favour though and add the reason for the patch (i.e. the gist
of the discussion) to the commit message. it's a valid change, avoiding |=
for logical values, but that should be stated.
thanks.

Cheers,
  Peter


More information about the xorg-devel mailing list