[PATCH] dix: do not use bit-wise operators on the boolean result of BitIsOn

Keith Packard keithp at keithp.com
Mon Nov 29 10:41:58 PST 2010


On Mon, 29 Nov 2010 17:47:31 +0100, Julien Cristau <jcristau at debian.org> wrote:
> On Mon, Nov 29, 2010 at 17:09:31 +0100, Ferry Huberts wrote:
> 
> > From: Ferry Huberts <ferry.huberts at pelagic.nl>
> > 
> > Signed-off-by: Ferry Huberts <ferry.huberts at pelagic.nl>
> > ---
> >  dix/getevents.c |   12 ++++++------
> >  1 files changed, 6 insertions(+), 6 deletions(-)
> > 
> I'm missing the "why" for this change.  It looks like a no-op to me...

Looks like a nice change to me -- if C had an actual boolean type, we'd
have been getting errors before. Sigh.

I've checked the server and don't see any other places using BitIsOn
with bit operations.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101129/75b6c7b4/attachment-0001.pgp>


More information about the xorg-devel mailing list