[PATCH 3/6] dix: when converting to XI 1.x events, use the first_valuator's device mode

Chase Douglas chase.douglas at canonical.com
Mon Nov 29 08:14:02 PST 2010


On 11/22/2010 10:35 PM, Peter Hutterer wrote:
> Don't stop processing events when a valuator's mode doesn't match the 0th
> valuator's mode. Instead, start with the first_valuator in the event and
> keep stacking them on until the first valuator with a different mode is hit.

In XI 1.x, a device has one mode. My implementation assumed that the
generated events must only have valuators that match that mode.

What is supposed to occur when the XI 1 device is absolute, the first
two valuators are absolute, the third is relative, and we are generating
an event with only the third valuator changed?

My understanding is that we shouldn't expose different mode valuators to
XI 1.x clients at all. Thus, the event shouldn't be sent at all if it's
sent as an XI 1.x event. However, I believe this patch would send the
third axis.

-- Chase


More information about the xorg-devel mailing list