[PATCH 1/2] Remove unused ReqLen & CastxReq macros

Jeremy Huddleston jeremyhu at apple.com
Sat Nov 27 21:49:07 PST 2010


Both:
Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

On Nov 27, 2010, at 13:46, Alan Coopersmith wrote:

> According to Xserver-spec, they were part of the now-deleted DBE "Idioms"
> code.   The last callers of them were removed in commits fe616f9230b6 &
> 3d642905477f.
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
> include/os.h |   23 -----------------------
> 1 files changed, 0 insertions(+), 23 deletions(-)
> 
> diff --git a/include/os.h b/include/os.h
> index efa202c..e882a0c 100644
> --- a/include/os.h
> +++ b/include/os.h
> @@ -441,29 +441,6 @@ extern _X_EXPORT int ddxProcessArgument(int /*argc*/, char * /*argv*/ [], int /*
> 
> extern _X_EXPORT void ddxUseMsg(void);
> 
> -/* int ReqLen(xReq *req, ClientPtr client)
> - * Given a pointer to a *complete* request, return its length in bytes.
> - * Note that if the request is a big request (as defined in the Big
> - * Requests extension), the macro lies by returning 4 less than the
> - * length that it actually occupies in the request buffer.  This is so you
> - * can blindly compare the length with the various sz_<request> constants
> - * in Xproto.h without having to know/care about big requests.
> - */
> -#define ReqLen(_pxReq, _client) \
> - ((_pxReq->length ? \
> -     (_client->swapped ? lswaps(_pxReq->length) : _pxReq->length) \
> -  : ((_client->swapped ? \
> -	lswapl(((CARD32*)_pxReq)[1]) : ((CARD32*)_pxReq)[1])-1) \
> -  ) << 2)
> -
> -/* otherReqTypePtr CastxReq(xReq *req, otherReqTypePtr)
> - * Cast the given request to one of type otherReqTypePtr to access
> - * fields beyond the length field.
> - */
> -#define CastxReq(_pxReq, otherReqTypePtr) \
> -    (_pxReq->length ? (otherReqTypePtr)_pxReq \
> -		    : (otherReqTypePtr)(((CARD32*)_pxReq)+1))
> -
> /* stuff for ReplyCallback */
> extern _X_EXPORT CallbackListPtr ReplyCallback;
> typedef struct {
> -- 
> 1.7.3.2
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel



More information about the xorg-devel mailing list