[PATCH] xfree86: Bump classic driver default to 1024x768

[Luc Verhaegen]

On Mon, Nov 15, 2010 at 11:25:13AM +1000, Peter Hutterer wrote:
> From: Adam Jackson <ajax at redhat.com>
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  hw/xfree86/common/xf86Mode.c |   21 ++++++++++++++++-----
>  1 files changed, 16 insertions(+), 5 deletions(-)
> 
> diff --git a/hw/xfree86/common/xf86Mode.c b/hw/xfree86/common/xf86Mode.c
> index d03310e..54fe021 100644
> --- a/hw/xfree86/common/xf86Mode.c
> +++ b/hw/xfree86/common/xf86Mode.c
> @@ -1402,6 +1402,7 @@ xf86ValidateModes(ScrnInfoPtr scrp, DisplayModePtr availModes,
>  	strategy &= ~LOOKUP_OPTIONAL_TOLERANCES;
>      } else {
>  	const char *type = "";
> +        Bool specified = FALSE;
>  
>  	if (scrp->monitor->nHsync <= 0) {
>  	    if (numTimings > 0) {
> @@ -1412,11 +1413,13 @@ xf86ValidateModes(ScrnInfoPtr scrp, DisplayModePtr availModes,
>  		}
>  	    } else {
>  		scrp->monitor->hsync[0].lo = 31.5;
> -		scrp->monitor->hsync[0].hi = 37.9;
> +		scrp->monitor->hsync[0].hi = 48.0;
>  		scrp->monitor->nHsync = 1;
>  	    }
>  	    type = "default ";
> -	}
> +	} else {
> +            specified = TRUE;
> +        }
>  	for (i = 0; i < scrp->monitor->nHsync; i++) {
>  	    if (scrp->monitor->hsync[i].lo == scrp->monitor->hsync[i].hi)
>  	      xf86DrvMsg(scrp->scrnIndex, X_INFO,
> @@ -1445,7 +1448,9 @@ xf86ValidateModes(ScrnInfoPtr scrp, DisplayModePtr availModes,
>  		scrp->monitor->nVrefresh = 1;
>  	    }
>  	    type = "default ";
> -	}
> +	} else {
> +            specified = TRUE;
> +        }
>  	for (i = 0; i < scrp->monitor->nVrefresh; i++) {
>  	    if (scrp->monitor->vrefresh[i].lo == scrp->monitor->vrefresh[i].hi)
>  	      xf86DrvMsg(scrp->scrnIndex, X_INFO,
> @@ -1459,10 +1464,16 @@ xf86ValidateModes(ScrnInfoPtr scrp, DisplayModePtr availModes,
>  			 scrp->monitor->vrefresh[i].lo,
>  			 scrp->monitor->vrefresh[i].hi);
>  	}
> +
> +        type = "";
> +	if (!scrp->monitor->maxPixClock && !specified) {
> +            type = "default ";
> +            scrp->monitor->maxPixClock = 65000.0;
> +        }
>  	if (scrp->monitor->maxPixClock) {
>  	    xf86DrvMsg(scrp->scrnIndex, X_INFO,
> -		       "%s: Using maximum pixel clock of %.2f MHz\n",
> -		       scrp->monitor->id,
> +		       "%s: Using %smaximum pixel clock of %.2f MHz\n",
> +		       scrp->monitor->id, type,
>  		       (float)scrp->monitor->maxPixClock / 1000.0);
>  	}
>      }
> -- 
> 1.7.3.2

Isn't the standard supposed to be those 14" vga fishbowls, which did 
only up to 1024x768 interlaced? Which is iirc, the timing given 
originally...

# 1024x768i @ 43Hz (industry standard) hsync: 35.5kHz
ModeLine "1024x768"   44.9 1024 1032 1208 1264    768  768  776  817 +hsync +vsync Interlace

Why change this, are we suddenly forgetting the whole of the 90s ever 
happened?

Luc Verhaegen.