Xv reput changes v2

Luc Verhaegen libv at skynet.be
Wed Nov 24 09:28:11 PST 2010


On Tue, Nov 02, 2010 at 08:05:46PM +0200, ville.syrjala at nokia.com wrote:
> Second installment of Xv reput changes.
> 
> Patches 09-13 are new. Patch 14 was modified. The rest should be the
> same as before.
> 
> ReputImage clipping should now match the behaviour of a regular
> XPutImage or a non-overlay XvPutImage fairly closely.
> 
> The ReputImage hook was changed to pass all the src/dst coordinates
> instead of just dst_x and dst_y. This isn't strictly necessary but
> leaving it out would require duplicate bookkeeping in the driver.
> 
> A call to the ModeSet hook was added to xf86DisableUnusedFunctions().
> 
> I think this set is pretty much done now. I'll wait for review comments
> before I'll touch it again.

The patchset fundamentally changes the use of reputimage. The extra 
arguments passed might need driver internal recalculation compared to 
before, as reputimage could've been sent because of a modechange.

I will commit changes to my unichrome driver repo soon, where scaling
is handled correctly (as on some unichrome hw this happens before 
overlays are blended in), and i have sent a fix for apm to the ml just 
now.

Nice work though,

Reviewed-by: Luc Verhaegen <luc.verhaegen at basyskom.de>

Luc Verhaegen.


More information about the xorg-devel mailing list