[PATCH 07/13] dix: reshuffle WindowOptRec to fill a hole on LP64

[Matt Turner]

On Wed, Nov 24, 2010 at 1:37 AM, Peter Harris <pharris at opentext.com> wrote:
> On 2010-11-23 20:10, Matt Turner wrote:
>> Probably just me not spotting the obvious, but I see
>>
>> xserver $ git grep 'VisualID' | grep typedef
>> hw/dmx/dmxclient.h:typedef unsigned long VisualID64;
>> hw/xnest/Xnest.h:typedef unsigned long VisualID64;
>>
>> So if CursorPtr is a pointer, it seems like VisualID will always be
>> the same size as CursorPtr. I guess they'd be different for ABIs like
>> MIPS/n32. I don't guess it hurts either way, as I don't know any
>> systems where sizeof(pointer) < sizeof(long).
>>
>> Maybe I'm not finding the correct definition of VisualID?
>
> You appear to have found VisualID64, which isn't used by the core as far
> as I can see.
>
> VisualID is #defined to CARD32 in Xproto.h (from proto/x11proto.git).

Sigh.

On 2010-11-23 20:10, Matt Turner wrote:
> Probably just me not spotting the obvious, but I see

Indeed.