[PATCH xserver 6/8] xmlrules.in: specify the xserver entities depedencies on the target

[Alan Coopersmith]

Gaetan Nadon wrote:
> On Thu, 2010-11-18 at 16:44 -0800, Alan Coopersmith wrote:
>> > +%.pdf: %.xml $(XML_ENT_DIR)/xserver.ent
> The generated files depend on xserver.ent which is what pattern rules
> allow you to do.
> This is not possible with the ".xml.html:" suffix rules.
>> >       $(AM_V_GEN)$(XMLTO) $(XMLTO_FLAGS) --with-fop pdf $<
>> >  endif
>> > 
>> > @@ -66,8 +66,3 @@ endif HAVE_XMLTO
>> > 
>> >  CLEAN_DOC_FILES = $(TXT_FILES) $(HTML_FILES) $(PDF_FILES)
>> > 
>> > -# All the files we build depend on the entities
>> > -$(BUILT_DOC_FILES): $(XML_ENT_DIR)/xserver.ent
> This target worked but is no longer needed due to pattern rules above.

Right - the two styles should be equivalent, but I suppose it's clearer listing
the dependency with the rule, instead of later on in the file.

>> > -
>> > -$(XML_ENT_DIR)/xserver.ent:
>> > -     (cd $(XML_ENT_DIR) && $(MAKE) $(AM_MAKEFLAGS) $(@F))
> My current level of understanding says it is impossible for this target
> to ever work,
> under any circumstances, even when invoked manually. It would have to be
> a PHONEY target.

Okay, I don't remember why I thought it was useful when I added it, and
can't come up with anything now other than a manual rebuild of just part
of the tree right after the rule was added without running configure first.
By now, everyone's had to run configure again anyway for other changes, so
even that doesn't seem possible/useful.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System