[PATCH xserver] xfree86: Don't install module .la files. (#4898)

Gaetan Nadon memsize at videotron.ca
Sat Nov 20 17:50:18 PST 2010


On Fri, 2010-11-19 at 21:39 -0500, Gaetan Nadon wrote:

> > +	rm -f $(moduledir)/multimedia/bt829_drv.la
> > +	rm -f $(moduledir)/multimedia/fi1236_drv.la
> > +	rm -f $(moduledir)/multimedia/msp3430_drv.la
> > +	rm -f $(moduledir)/multimedia/tda8425_drv.la
> > +	rm -f $(moduledir)/multimedia/tda9850_drv.la
> > +	rm -f $(moduledir)/multimedia/tda9885_drv.la
> > +	rm -f $(moduledir)/multimedia/uda1380_drv.la
> 
> 
> All of the remove commands should have $(AM_V_GEN) in front of the rm
> command for the silent rules.


What I should have been suggesting is to use $(AM_V_at) as it is used in
several places in the server already.

        hw/xfree86/Makefile.in:	$(AM_V_at)rm -f Xorg && $(MAKE) Xorg

It will simply suppress the output. As Alan pointed out, it is not very
important as the output
for "install" is fairly busy anyway. However, in Makefile.am it will
show that this target has been taken care of
like all others and it will prevent someone from adding $(AM_V_GEN).

If there is a low cost opportunity to do it...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101120/edd832d6/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101120/edd832d6/attachment.pgp>


More information about the xorg-devel mailing list