[PATCH xserver] xfree86: Don't install module .la files. (#4898)

Alan Coopersmith alan.coopersmith at oracle.com
Fri Nov 19 19:06:31 PST 2010


Gaetan Nadon wrote:
> On Fri, 2010-11-19 at 14:59 -0800, Jesse Adkins wrote:
>> Signed-off-by: Jesse Adkins <jesserayadkins at gmail.com <mailto:jesserayadkins at gmail.com>>
>> ---
>>  hw/xfree86/i2c/Makefile.am |   10 ++++++++++
>>  1 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/xfree86/i2c/Makefile.am b/hw/xfree86/i2c/Makefile.am
>> index 0b80cc8..5e1b553 100644
>> --- a/hw/xfree86/i2c/Makefile.am
>> +++ b/hw/xfree86/i2c/Makefile.am
>> @@ -41,3 +41,13 @@ tda9885_drv_la_SOURCES = tda9885.c tda9885.h tda9885_module.c
>>  
>>  uda1380_drv_la_LDFLAGS = -module -avoid-version
>>  uda1380_drv_la_SOURCES = uda1380.c uda1380.h uda1380_module.c
>> +
>> +# We don't use the .la's, so remove them.
>> +install-data-hook:
>> +	rm -f $(moduledir)/multimedia/bt829_drv.la
>> +	rm -f $(moduledir)/multimedia/fi1236_drv.la
>> +	rm -f $(moduledir)/multimedia/msp3430_drv.la
>> +	rm -f $(moduledir)/multimedia/tda8425_drv.la
>> +	rm -f $(moduledir)/multimedia/tda9850_drv.la
>> +	rm -f $(moduledir)/multimedia/tda9885_drv.la
>> +	rm -f $(moduledir)/multimedia/uda1380_drv.la
> 
> All of the remove commands should have $(AM_V_GEN) in front of the rm
> command for the silent rules.

Wouldn't that be misleading as GEN implies a file was generated, not removed?

Also, the silent rules don't seem to apply to install steps - those are pretty
noisy still.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list