[RFC XI 2.1 - xinput 2/3] Zero out entire mask when selecting for raw events

Peter Hutterer peter.hutterer at who-t.net
Tue Nov 16 21:24:13 PST 2010


On Fri, Nov 12, 2010 at 05:35:16PM -0500, Chase Douglas wrote:
> From: Chase Douglas <chase.douglas at ubuntu.com>
> 
> Signed-off-by: Chase Douglas <chase.douglas at canonical.com>
> ---
>  src/test_xi2.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/test_xi2.c b/src/test_xi2.c
> index fea36a8..30bb0fa 100644
> --- a/src/test_xi2.c
> +++ b/src/test_xi2.c
> @@ -339,7 +339,7 @@ test_xi2(Display	*display,
>      }
>  
>      mask.deviceid = XIAllMasterDevices;
> -    memset(mask.mask, 0, 2);
> +    memset(mask.mask, 0, mask.mask_len);

shouldn't the same be done for the XIGrabModifiers path about 15 lines up
for consistency?

Cheers,
  Peter

>      XISetMask(mask.mask, XI_RawKeyPress);
>      XISetMask(mask.mask, XI_RawKeyRelease);
>      XISetMask(mask.mask, XI_RawButtonPress);
> -- 
> 1.7.1
> 


More information about the xorg-devel mailing list