[PATCH] xfree86: rename allowEmptyInput to forceInputDevices.

Peter Hutterer peter.hutterer at who-t.net
Sun Nov 14 22:27:17 PST 2010


On Mon, Nov 15, 2010 at 04:57:14PM +1030, Benjamin Close wrote:
>  On 11/11/10 20:05, Julien Cristau wrote:
> >On Thu, Nov 11, 2010 at 10:08:20 +0100, Matthieu Herrb wrote:
> >
> >>I don't see a diff hunk to actually rename the option in xorg.conf
> >>and provide backward compatibility with the previous name, nor any
> >>associated documentation update.
> >>
> >>Am I missing something or what are your intents wrt the option name
> >>for xorg.conf?
> >I guess you missed this one:
> >http://cgit.freedesktop.org/xorg/xserver/commit/?id=ec1bfbc66926130e1153facc3b92ee175f1cb6b6
> >
> 
> That patch simply removes the AllowEmptyInput option. There is still
> nothing documented about the new name. Ie a user *wants* the option
> and suddenly it's renamed from underneath them with no explanation
> on what to use as an alternative.

Note that we need to differ between the user option and the server variable.
The user option was removed in ec1bfb, so there isn't any new name to
document. And that's done intentionally, I haven't seen a legitimate use of
AllowEmptyInput in over a year or so, but plenty of invalid ones that
usually result in no input devices, too many input devices, duplicate
events and of course bugreports.

The rename here is for a server-internal variable that is not exposed to the
user.

Cheers,
  Peter


More information about the xorg-devel mailing list