[PATCH 2/2] XQuartz: Fix make distcheck

Cyril Brulebois kibi at debian.org
Sat Nov 13 16:28:47 PST 2010


Jeremy Huddleston <jeremyhu at apple.com> (13/11/2010):
> -	$(RM) -rf $(DESTDIR)$(APPLE_APPLICATIONS_DIR)/$(APPLE_APPLICATION_NAME).app	
> +	$(RM) -rf $(DESTDIR)$(APPLE_APPLICATIONS_DIR)/$(APPLE_APPLICATION_NAME).app/Contents/{Resources,Info.plist,PkgInfo}

You're relying on shell expansion of “foo/{bar,baz}” into “foo/bar
foo/baz” but that's not POSIX, and a minimal shell will fail with
ENOENT on “foo/{bar,baz}”.

Example:
| $ dash -c 'mkdir -p /tmp/foo/{bar,baz} && ls /tmp/foo'
| {bar,baz}

Mraw,
KiBi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101114/c5f56a9f/attachment.pgp>


More information about the xorg-devel mailing list