Even more warning fixes

[Cyril Brulebois]

Jamey Sharp <jamey at minilop.net> (12/11/2010):
> Oh, wait. You don't need the conditionals or the lookup_ret variable
> here at all: the result pointer is already guaranteed to be NULL if
> the return value is not Success.

I guess dix/deprecated.c should be adjusted accordingly, then?

> I guess I'm willing to stick my reviewed-by on these warning fixes
> either way, but I'd prefer to not add the unnecessary checks.

I can resend a series without those.

> Also, you might consider casting the first argument of
> dixLookupResourceBy* to (pointer*), rather than (pointer). The
> compiler doesn't care since they're both compatible with (void*),
> but (pointer*) is better documentation.

Will include that in the next series.

Mraw,
KiBi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101112/9a1e07f3/attachment.pgp>