[PATCH modular] Remove -f and -r options.

Dan Nicholson dbn.lists at gmail.com
Thu Nov 11 12:23:48 PST 2010


On Fri, Nov 5, 2010 at 7:55 AM, Trevor Woerner <twoerner at gmail.com> wrote:
> From: Trevor Woerner <twoerner at gmail.com>
>
> Since the script includes an --autoresume option, which is essentially
> the combination of the -f and -r options, the individual options not
> necessary anymore by themselves.
>
> Signed-off-by: Trevor Woerner <twoerner at gmail.com>
> ---
>  build.sh |   15 +--------------
>  1 files changed, 1 insertions(+), 14 deletions(-)
>
> I can easily see why someone wouldn't want these removed, since it is a
> change to an established API. However, with the --autoresume option there
> really isn't any need to use the -f and -r individually (which you would
> almost always use together) since what they do together can be done more
> easily with the one --autoresume option.
>
> So unless there's a specific case where using --autoresume can't do
> something -f and -r can it would be nice to clean up the build script
> by removing options which are no longer necessary.

Why don't you make -f and -r map to --autoresume instead of removing
them. That seems like the nice thing to do. In fact, I'd think
-f/--file would be a nicer option name to keep than --autoresume. I
know Peter uses -f and -r, so he might have an opinion.

--
Dan


More information about the xorg-devel mailing list