[PATCH v2] xfree86: remove user-configured AllowEmptyInput

Dan Nicholson dbn.lists at gmail.com
Tue Nov 9 17:27:31 PST 2010


On Tue, Nov 9, 2010 at 4:23 PM, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> An estimated 100% (rounded down to the nearest percent) of the people who
> have this in their configuration don't actually know what this option does.
> Protect the users from themselves.
>
> IIRC, AEI on was useful for some time between 1.4 and 1.5 and never since.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> Changes to v1:
> - remove two more mentions of AllowEmptyInput from error messages, hunks 3
>  and 4
>
> Hunk 3 has a different error message now. You can only get here if you have
> compiled your server without hal and without udev, but explicitly enabled
> hotplugging in the xorg.conf (default if compiled without config backed is
> hotplugging off). So the user has to put some effort in to get here, so
> warn about it but start the server without input devices nonetheless.

Looks good to me.

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>


More information about the xorg-devel mailing list