[PATCH 1/3] Xi: split hierarchy manipulation into static functions.

[Julien Cristau]

On Mon, Nov  8, 2010 at 10:06:31 +1000, Peter Hutterer wrote:

[...]
> +static int
> +remove_master(ClientPtr client, xXIRemoveMasterInfo *r,
> +              int flags[MAXDEVICES])
> +{
> +    DeviceIntPtr ptr, keybd, XTestptr, XTestkeybd;
> +    int rc = Success;
> +
> +    if (r->return_mode != XIAttachToMaster &&
> +        r->return_mode != XIFloating)
> +        return BadValue;
> +
Probably for a followup patch, but set client->errorValue to
r->return_mode here?  There's a couple other places around there that
might want to set errorValue as well, I think.

For the patch itself,
Reviewed-by: Julien Cristau <jcristau at debian.org>

Cheers,
Julien