[PATCH] xfree86: fix two compiler warnings - unused variable ati, atimisc

Mark Kettenis mark.kettenis at xs4all.nl
Fri Nov 5 02:10:10 PDT 2010


> X-Original-To: xorg-devel at lists.freedesktop.org
> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
> 	h=domainkey-signature:received:mime-version:received:in-reply-to
> 	:references:from:date:message-id:subject:to:cc:content-type
> 	:content-transfer-encoding;
> 	bh=6d+HU+AjROuRO4tDgwj+LN7RLVIiIHPJbqISg2heumY=;
> 	b=oCVxewqbxpsaFENGvcWXD4niCDkQ619y5Cupe9bURzTolUhdq/bd4dy6N+gO8azmWp
> 	cTdeSLnISHu1JdqqO0+l+J3x43ualqaFA2Uq24gmjaLWH2KxUF6+7+OCAWXD8eQ/wVxu
> 	KPibDnh2oYJK5YGOGEl+2ewO+drFC3Ii/udUo=
> DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
> 	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
> 	:cc:content-type:content-transfer-encoding;
> 	b=UyzTT/va6nqwe+aMs8oZUAc3rpQDntsKtRWfsC3axEumDoxsm4JFcivHv+M70NxC4n
> 	kjUJCdI+sx7s2XrT42cgy4TQCVTyrcVhL3re9PS8rKkGFZogBWkXiwirKxxt6Q1Plmrt
> 	JdopR5KfZwmGx12JwghaWDzSWumokzEKYduc4=
> From: Matt Turner <mattst88 at gmail.com>
> Date: Thu, 4 Nov 2010 23:08:03 -0400
> 
> On Thu, Nov 4, 2010 at 10:45 PM, Peter Hutterer
> <peter.hutterer at who-t.net> wrote:
> > ./../../../hw/xfree86/common/xf86Config.c: In function
> > 'fixup_video_driver_list':
> > ./../../../hw/xfree86/common/xf86Config.c:507:19: warning: unused variable
> > 'atimisc'
> > ./../../../hw/xfree86/common/xf86Config.c:507:12: warning: unused variable
> > 'ati'
> >
> > Introduced in 52577ae8eeda64601db8dd425027cf8e4271b873.
> >
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> > ---
> >  hw/xfree86/common/xf86Config.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c
> > index 92fb74d..dea3c9b 100644
> > --- a/hw/xfree86/common/xf86Config.c
> > +++ b/hw/xfree86/common/xf86Config.c
> > @@ -504,7 +504,6 @@ fixup_video_driver_list(char **drivers)
> >     static const char *fallback[4] = { "vesa", "fbdev", "wsfb", NULL };
> >     char **end, **drv;
> >     char *x;
> > -    char **ati, **atimisc;
> >     int i;
> >
> >     /* walk to the end of the list */
> > --
> > 1.7.3.2
> 
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
> 
> ati and atimisc are still listed, along with lots of other dead and
> outdated modules, in hw/xfree86/doc/devel/Registry.

Perhaps that isn't such a bad thing?  I mean, re-using those names is
probably a bad idea.


More information about the xorg-devel mailing list