[PATCH v3] dix: adds support for none root window background

[Daniel Stone]

On Wed, Nov 03, 2010 at 11:17:06PM +0200, Tiago Vignatti wrote:
> It lets the driver notify the server whether it can draw a background when
> '-background none' option is used by the system platform. Use cases for that
> could be video drivers performing mode-setting in kernel time, before X is up,
> so a seamless transition would happen until X clients start to show up.
> 
> If the driver can copy the framebuffer cleanly then it can set the flag
> (canDoBGNoneRoot), otherwise the server will fallback to the normal behaviour.
> The system must explicit indicates willingness of doing so through
> '-background none'. We could do this option as default; in such case,
> malicious users would be able to steal the framebuffer with a bit of tricks.

Looks good to me now, although if someone calls ChangeWindowAttributes
(the protocol request) setting the root's BackPixmap to None,
ChangeWindowAttributes() will call MakeRootTile().  Admittedly this is
equally broken with -wr and -br, but might be nice to fix with a
follow-up patch. :)

Anyway, Reviewed-by: Daniel Stone <daniel at fooishbar.org>

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101105/c394e056/attachment-0001.pgp>