[PATCH v2] dix: adds support for none root window background

[Daniel Stone]

Hi,

On Wed, Nov 03, 2010 at 08:00:45PM +0200, Tiago Vignatti wrote:
> @@ -502,6 +502,7 @@ void UseMsg(void)
>  #endif
>      ErrorF("-nolisten string       don't listen on protocol\n");
>      ErrorF("-noreset               don't reset after last client exists\n");
> +    ErrorF("-nr                    create root window with no background\n");
>      ErrorF("-reset                 reset after last client exists\n");
>      ErrorF("-p #                   screen-saver pattern duration (minutes)\n");
>      ErrorF("-pn                    accept failure to listen on all ports\n");
> @@ -842,6 +843,8 @@ ProcessCommandLine(int argc, char *argv[])
>  	    defaultBackingStore = WhenMapped;
>          else if ( strcmp( argv[i], "-wr") == 0)
>              whiteRoot = TRUE;
> +        else if ( strcmp( argv[i], "-nr") == 0)
> +            bgNoneRoot = TRUE;
>          else if ( strcmp( argv[i], "-maxbigreqsize") == 0) {
>               if(++i < argc) {
>                   long reqSizeArg = atol(argv[i]);

The patch pretty much looks fine to me, but if you're interested in
cleaning up our arguments, how about keeping -wr and -br for
backwards-compatibility, but adding a single flag, like
-background {white,black,transparent,arseuglyweave}?

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101104/f584cb3f/attachment-0001.pgp>