[PATCH] build.sh: allow tarballs with --modfile

[Simon Braunschmidt]

On 11/03/2010 01:21 PM, Trevor Woerner wrote:
> On Wed, Nov 3, 2010 at 8:20 AM, Trevor Woerner<twoerner at gmail.com>  wrote:
>> In an effort to make the script "smarter", I have created an
>> additional patch on top of yours whereby:
>
> if the user is using the --modfile option AND
>
>> if the user forgets to provide the --clone flag and there are neither
>> sources nor tarballs, assume they should have provided the --clone
>> flag and grab the sources from git. Would that be an unexpected
>> assumption? (I'll be sending that patch shortly after sending this
>> email)

For my taste this would be a bit of "overdesign" resp. outsmarting the 
user.

What if the user happens to call the utils/modular/build.sh script from 
the wrong position in the filesystem. The script would then probably 
download the sources again, littering the users directories with 
unexpected git repositories, building pristine upstream sources instead 
of the already downloaded sources that the user may have changed before.

I think that the current behaviour is good, add the missing module to 
the nonexistent_components list, proceed or maybe stop and let the user 
get its part of the configuration cleaned up.

I think a helpful error message is always more welcome than a lot of 
clever mechanism/policy inside such a script without being able to take 
into account the situation on the users machine. How about:

"The build.sh script could not find any of: "
"1. a checked out git repository at $1/$2"
"2. a src tarball for $2 in ./$1/ or ./"
"You may want to provide the --clone option to build.sh to"
"automatically git-clone $1/$2 as part of the build"

As part of the nonexisten_components output at the end of the script.

I will provide a patch for this proposal.

Regards, Gruessle
Simon