[PATCH] build.sh: allow tarballs with --modfile

[Trevor Woerner]

Thanks for sending me the patch. Yes, there's no doubt, when I added
the --modfile option I absolutely assumed the user would be building
from git sources; enabling --clone definitely ignores building from
tarballs.

I agree that your patch is required:

Reviewed-by: Trevor Woerner <twoerner at gmail.com>

In an effort to make the script "smarter", I have created an
additional patch on top of yours whereby:
if the user forgets to provide the --clone flag and there are neither
sources nor tarballs, assume they should have provided the --clone
flag and grab the sources from git. Would that be an unexpected
assumption? (I'll be sending that patch shortly after sending this
email)

On Wed, Nov 3, 2010 at 7:21 AM, Simon Braunschmidt <sb at emlix.com> wrote:
> I would rather suggest to get rid of/obsolete build-from-tarballs.sh and
> manage it all from build.sh.
>
...
> Would patches to integrate all of build-from-tarballs.sh into build.sh with
> the purpose to remove build-form-tarballs.sh be accepted?

I think this would be a good cleanup.