[PATCH:xbiff] Convert checks for mailbox directory from ifdefs to autoconf tests

[Dan Nicholson]

On Mon, Nov 1, 2010 at 2:28 AM, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
>> From: Alan Coopersmith <alan.coopersmith at oracle.com>
>> Date: Sun, 31 Oct 2010 13:45:15 -0700
>
> I'm not quite sure this is a good idea.  The outcome of the autoconf
> checks you're introducing depends on particularities of the build
> system.  I have seen setups where sysadmins have created /var/mail by
> hand where the system default was /var/spool/mail.  An xbiff binary
> compiled on such a system would not work on an unmodified system.
>
> Not sure this really matters.  Most modern systems provide a BSD-style
> <paths.h> and on Solaris /var/mail seems to be the preferred mail
> directory and that's the one you check first.
>
> The check defenitely won't work for cross-compilation though.

That's why it bails when cross compiling before going to the bare path
checks and forces you to set MAILBOX_DIRECTORY. I believe
AC_CHECK_HEADER/AC_CHECK_DECL are cross compiling aware so that you'd
pick up the host system's paths.h.

The only thing I'd change is to make MAILBOX_DIRECTORY accessible from
--with-mailbox-directory or something instead of just an AC_ARG_VAR.

--
Dan