[PATCH 11/11] xfree86: move all pci code from auto configurator into a meaningful location
Julien Cristau
jcristau at debian.org
Mon May 31 06:50:49 PDT 2010
On Fri, May 21, 2010 at 14:43:24 +0300, Tiago Vignatti wrote:
> This patch creates the private xf86PciMatchDriver hook, which goes inside pci
> code to match the drivers found in the system.
>
> Now there's no direct references to PCI inside xf86AutoConfig.c anymore.
>
> Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>
> ---
> hw/xfree86/common/xf86AutoConfig.c | 248 +-----------------------------------
> hw/xfree86/common/xf86pciBus.c | 252 ++++++++++++++++++++++++++++++++++++
> hw/xfree86/common/xf86pciBus.h | 1 +
> 3 files changed, 255 insertions(+), 246 deletions(-)
>
> diff --git a/hw/xfree86/common/xf86AutoConfig.c b/hw/xfree86/common/xf86AutoConfig.c
> index 896f695..8947a4f 100644
> --- a/hw/xfree86/common/xf86AutoConfig.c
> +++ b/hw/xfree86/common/xf86AutoConfig.c
> @@ -39,10 +39,10 @@
> #include "xf86Config.h"
> #include "xf86Priv.h"
> #include "xf86_OSlib.h"
> +#include "xf86pciBus.h"
> #ifdef __sparc__
> # include "xf86sbusBus.h"
> #endif
> -#include "dirent.h"
>
> #ifdef sun
> # include <sys/visual_io.h>
So it's not clear to me why pci has to go, but sbus can stay (not
interested in "because nokia doesn't build on sparc so we don't care").
Doesn't make a lot of sense to me to treat these differently, and the
commit message doesn't really explain why pci references are bad.
Cheers,
Julien
More information about the xorg-devel
mailing list