Xcomposite depends on Xfixes: unneccessary?

Julien Cristau jcristau at debian.org
Fri May 28 10:41:39 PDT 2010


On Fri, May 28, 2010 at 10:14:04 -0700, Philip Brown wrote:

> Hello,
> 
> After attempting to compile libXcomposite by itself, i hit the
> "requires Xfixes" dependency.
> However... I've been examining Xcomposite a bit, purely at the code
> level, and I don't see any actual reference to Xfixes at all.
> ...apart from including the Xfixes.h header file, that is!
> 
> Why is a dependency defined?
> 
> If it is not really necessary, then may I suggest a patch of
> 
> --- Xcomposite.h.orig   Fri May 28 19:02:03 2010
> +++ Xcomposite.h        Fri May 28 19:02:11 2010
> @@ -44,7 +44,6 @@
>  #define _XCOMPOSITE_H_
> 
>  #include <X11/extensions/composite.h>
> -#include <X11/extensions/Xfixes.h>
>  #include <X11/Xfuncproto.h>
> 
Xfixes.h defines XserverRegion, which is the return type of
XCompositeCreateRegionFromBorderClip().

Cheers,
Julien


More information about the xorg-devel mailing list