[PATCH] Don't ValidateTree/expose when changing the input shape

[Keith Packard]

On Wed, 26 May 2010 16:57:02 -0700, "Pierre-Loup A. Griffais" <pgriffais at nvidia.com> wrote:
> ValidateTree can be pretty expensive; gnome-shell floods the server with input 
> shape requests when animating windows, so that change makes it perform a lot better.
> 
> Aaron suggested Keith and Adam as reviewers; are the SetWinSize, SetBorderSize, 
> ResizeChildrenWinSize also unneeded when changing the input shape? The only 
> thing that looks needed for sure is CheckCursorConfinement(), but I have my 
> doubts about the rest.

The only thing necessary when changing the input shape is
WindowsRestructured and CheckCursorConfinement, both of which deal with
input. None of the rest of that function is necessary at all. I'd
suggest not abusing 'WasViewable' for this purpose and instead simply
wrapping most of the function in the test of which shape is being set.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100527/1edc027c/attachment.pgp>