[PATCH] Add a "flags" field to DeleteInputDeviceRequest.

Peter Hutterer peter.hutterer at who-t.net
Tue May 25 15:58:00 PDT 2010


On Tue, May 25, 2010 at 10:26:26AM -0700, Keith Packard wrote:
> On Thu, 20 May 2010 18:07:12 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> 
> > Also bumps XINPUT ABI.
> 
> We haven't been bumping this but once a release, and Tiago already hit
> this in April.

I disagree with this approach. Bumping the ABI once is fine enough for ABI
changes, but bumping it for API changes is quite helpful for bisecting.

All the input drivers support multiple server versions so we got a few
ifdefs in the code to handle that. If merge API changes later with an ABI
that's already been in place for months you need to sync up the input
drivers with the server just to work around this. If you simply bump
it a second time, you don't need to do any of that, just rebuild the drivers
and you're done.

IIRC we've bumped the ABI multiple times within a release before, so unless
we're running out of numbers really soon I don't see a reason why not to do
it two or three times per server version.

Note that the bisecting issue hurts me the least since I generally know what
version of the input drivers need which commits to build again. Others may
want to spend the time on figuring this out but I somehow doubt it.

Cheers,
  Peter



More information about the xorg-devel mailing list