[PATCH] xfixes: Remove the invisible cursor sprite, using NullCursor instead.

Oliver McFadden oliver.mcfadden at nokia.com
Mon May 24 22:05:35 PDT 2010


Oops; forgot to reply-to-all.

On Tue, 2010-05-25 at 07:17 +0300, Oliver McFadden wrote:
> On Tue, 2010-05-25 at 05:00 +0200, ext Jamey Sharp wrote:
> > Hi Oliver!
> > 
> > On Mon, May 24, 2010 at 7:45 PM, Oliver McFadden
> > <oliver.mcfadden at nokia.com> wrote:
> > > I'll check this today on my hardware; I think there I might have had a
> > > bug in the logic of my v2 patch. I'll let you know whether this one
> > > works.
> > 
> > Cool, thanks! If it works please post a Tested-by and Cc Keith.
> 
> I guess both S-o-b and Tested-by would be more appropriate?
> 
> > I have an N900 (which is quite cool!) but I don't feel quite up to
> > running experimental code on my phone. :-)
> 
> Yeah, no problem; I'm compiling the server now. Expect results in a few
> minutes. (Glad you like the phone :)
> 
> > > P.S. Thanks for picking this up; I've been busy at work with some
> > > upgrades.
> > 
> > I'm hoping to get this merged soon so Keith can drop his lazy-creation
> > patch from his fix-private-usage branch, and then I hope he'll finally
> > get that branch merged.
> 
> Ok. I'll reply with the testing results and if successful bring Keith
> into CC.

Testing was successful. There are still a few damage events generated
during server startup (before we call XFixesHideCursor) however these
can be totally avoided by running with the -nocursor option, so that's
fine.

For dynamically switchable configurations, this isn't a problem.

I will reply to the original patch email with S-o-b and Tested-by, and
add Keith to CC.

> 
> -- Oliver.




More information about the xorg-devel mailing list