[PATCH 1/2] xfree86: vgaarb: simplify the arguments passed to lock/unlock

[Vignatti Tiago (Nokia-D/Helsinki)]

On Fri, May 21, 2010 at 09:46:56PM +0200, ext Keith Packard wrote:
> On Fri, 21 May 2010 20:49:06 +0300, "Vignatti Tiago (Nokia-D/Helsinki)" <tiago.vignatti at nokia.com> wrote:
> 
> > You gave the nak for the wrong patch from the series, right? First patch is 
> > only a cleanup.
> 
> No, it's not a cleanup, it's an API change which passes the job of
> computing the argument into the lower level function. Using a nice typed
> pointer is "safer" than passing a bare int. The motivation for this
> change was to change the implementation to use the Screen instead of the
> ScrnInt, although I'm not sure why you want to make this change.

But the motivation goes a bit further: is to hide vgaDev from those
structures. So if it's inside ScreenRec or ScrnInfoRec, it doesn't really
matter to me. I just want to go now and hide it for mortals (I don't think
mostly machines nowadays do VGA legacy decoding for GPUs and have PCI buses).


Therefore, I'll hide vgaDev in ScrnInfoRec privates, if nothing sounds weird
for you? 


Cheers,

    Tiago