clang static analysis

Thomas Dickey dickey at
Sun May 23 08:41:56 PDT 2010

On Sat, May 22, 2010 at 08:11:29PM -0700, Keith Packard wrote:
> On Sat, 22 May 2010 09:16:48 -0700, Jeremy Huddleston <jeremyhu at> wrote:
> > I think in this case, miFillPolyHelper should take a const pGC and
> > pass it casted to non-const to ChangeGC (since it knows it will be
> > preserved by another handshaking method).
> Yuck. I'd rather not see the server cluttered by casts in the name of
> adding 'const' everywhere. It's just not that useful.

In most cases, that simply indicates that the problem isn't superficial,
and requires some work.

fwiw, I use this patch to filter out some of the longstanding deficiences
in X's headers.

ymmv / awai

Thomas E. Dickey <dickey at>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: X11-const.patch
Type: text/x-diff
Size: 1011 bytes
Desc: not available
URL: <>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <>

More information about the xorg-devel mailing list