[PATCH 1/4] Move region implementation from mi to dix.

Jamey Sharp jamey at minilop.net
Fri May 21 15:36:07 PDT 2010


On Fri, May 21, 2010 at 3:14 PM, Keith Packard <keithp at keithp.com> wrote:
> On Fri, 21 May 2010 13:27:20 -0700, Jamey Sharp <jamey at minilop.net> wrote:
>> It looks like renaming miSubtractSpans to SubtractSpans was an accident?
>>
>> With that fixed, this looks perfectly sensible.
>
> Yeah, the sed script was a bit incautious. I've fixed the sed script and
> regenerated the branch.

You even incorporated a change I hadn't finished writing an e-mail to
suggest. Strong work. :-)

Seems like the deletions of "mi" prefixes in region.c should still go
in this first commit, though, not in "Change region implementation
from macros to inline functions". The latter looks kind of broken now.

Also, it looks like you ran fix-miregion over fix-miregion. Oops.

> In particular, I've split the huge patch into two pieces, the first is
> purely mechanical and done with the fix-region sed-script, the second
> patch is the needed fix-ups to make it actually work. When merging this
> to the server, I would smash those two together to make it bi-sectable,
> but for review I've split them apart to make it easier to see the two
> steps.

Good plan. That does help.

Jamey


More information about the xorg-devel mailing list