[PATCH 03/11] xfree86: bus: move IOADDRESS definition to a common header file

Vignatti Tiago (Nokia-D/Helsinki) tiago.vignatti at nokia.com
Fri May 21 10:04:48 PDT 2010


On Fri, May 21, 2010 at 04:21:26PM +0200, ext Alan Coopersmith wrote:
> Tiago Vignatti wrote:
> > IOADDRESS type definition encompass more than just pci code, so move it to
> > common.
> > 
> > Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>
> > ---
> >  hw/xfree86/common/xf86str.h         |    1 +
> >  hw/xfree86/os-support/bus/xf86Pci.h |    3 +--
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/hw/xfree86/common/xf86str.h b/hw/xfree86/common/xf86str.h
> > index de1f1b6..485c15a 100644
> > --- a/hw/xfree86/common/xf86str.h
> > +++ b/hw/xfree86/common/xf86str.h
> > @@ -58,6 +58,7 @@ typedef uint64_t memType;
> >  typedef uintptr_t memType;
> >  #endif
> >  
> > +typedef unsigned long IOADDRESS;    /* Must be large enough for a pointer */
> 
> If it must be large enough for a pointer, why not use uintptr_t like the code
> two lines before it?

I don't know. Seems uintptr_t is "unsigned int" in Linux, does it seems enough
to carry IO address there? Ajax?

        Tiago


More information about the xorg-devel mailing list