[PATCH] dix: Remove a large pile of backing store leftovers

Dan Nicholson dbn.lists at gmail.com
Thu May 20 15:09:42 PDT 2010


On Wed, May 19, 2010 at 8:42 AM, Adam Jackson <ajax at nwnk.net> wrote:
> On Tue, 2010-05-18 at 15:27 -0700, Keith Packard wrote:
>> On Tue, 18 May 2010 17:57:31 -0400, Adam Jackson <ajax at redhat.com> wrote:
>> >  void
>> >  miInitializeBackingStore (ScreenPtr pScreen)
>> >  {
>> > -    pScreen->SaveDoomedAreas = NULL;
>> > -    pScreen->RestoreAreas = NULL;
>> > -    pScreen->ExposeCopy = NULL;
>> > -    pScreen->TranslateBackingStore = NULL;
>> > -    pScreen->ClearBackingStore = NULL;
>> > -    pScreen->DrawGuarantee = NULL;
>> >  }
>>
>> Can we remove this function? It hasn't done anything useful for a long
>> time.
>
> I bet we can macro it away in the autoconf for the drivers, sure.
> Something like this might work:
>
> AC_CHECK_DECL(miInitializeBackingStore,
>              [],
>              [AC_DEFINE(miInitializeBackingStore())],
>              [#include "mibstore.h"])
>
> Dan or Gaetan or some other autoconf wizard feel like checking my work
> there?

I haven't really used AC_CHECK_DECL before, but reading the docs it
looks AC_CHECK_DECLS does what you want:

AC_CHECK_DECLS([miInitializeBackingStore], [], [], [#include <mibstore.h>])

Which then defines HAVE_DECL_MIINITIALIZEBACKINGSTORE to 1 or 0 appropriately.

http://www.gnu.org/software/autoconf/manual/autoconf.html#Generic-Declarations

--
Dan


More information about the xorg-devel mailing list