[PATCH 06/11] xfree86: Refactor InputClass matching code

Dan Nicholson dbn.lists at gmail.com
Thu May 20 09:48:48 PDT 2010


On Thu, May 20, 2010 at 9:40 AM, Jamey Sharp <jamey at minilop.net> wrote:
> Cool, that's a nice refactoring. In MatchAttrToken you could go a
> little further even, replacing "match = TRUE" with "return TRUE" and
> "return match" with "return FALSE", but either way,
> Reviewed-by: Jamey Sharp <jamey at minilop.net>

Oh, good point. That was a carryover from InputClassMatches having a
bunch of nested blocks, but it's easier in a separate function. I'll
respin that part.

Thanks.

--
Dan


More information about the xorg-devel mailing list