[PATCH 3/5 v4] Show Xserver release/version date in DIX & DDX docs

Dan Nicholson dbn.lists at gmail.com
Thu May 20 06:56:36 PDT 2010


On Wed, May 19, 2010 at 9:56 AM, Alan Coopersmith
<alan.coopersmith at oracle.com> wrote:
> Mark Kettenis wrote:
>>> From: Alan Coopersmith <alan.coopersmith at oracle.com>
>>> Dan Nicholson wrote:
>>>> On Tue, May 18, 2010 at 3:51 PM, Alan Coopersmith
>>>>> +       (cd $(XML_ENT_DIR) && $(MAKE) $(AM_MAKEFLAGS) $(@F))
>>>> Is $(@F) a gnu makeism? I can't tell, but I don't think so.
>>> I first learned about it when using Solaris make, and since it also worked
>>> with GNU make, I assumed it was fairly common but didn't check, since GNU
>>> make is currently required to build the Xorg server due to the "sinclude"
>>> usage in the exported interfaces list generation in the module loader.
>>
>> That is unfortunate.  On OpenBSD we do build Xorg with our own (BSD)
>> make.  Please try to avoid using GNU-isms.
>
> You're preaching to the choir here.   I try to build as much as possible with
> Solaris make, and often have to fix the GNU-make-ism's that don't get caught
> in review, but I've never taken the time to work out a portable solution to
> the sdksyms/sinclude stuff in hw/xfree86/loader/Makefile.am

Does Solaris make support "include"? You can try this trick to fool
automake into not interpreting the include statement:

DEPFILE = $(builddir)/sdksyms.dep
include $(DEPFILE)

Since the include statement includes a non-automake variable, automake
has no choice but let it through. Then it gets resolved at build time.

--
Dan


More information about the xorg-devel mailing list