[PATCH] dix: Remove a large pile of backing store leftovers

[Keith Packard]

On Wed, 19 May 2010 11:42:10 -0400, Adam Jackson <ajax at nwnk.net> wrote:

> Just a bit in the long bitfield list in WindowRec?  No reason to burn a
> whole int on it.  Although we're remarkably close to running over an int
> there too.

We can make more :-)

> I bet we can macro it away in the autoconf for the drivers, sure.
> Something like this might work:

Or just a static inline in mibstore.h that is marked as deprecated and
does nothing?

> And we don't anyway; we're removing the call to
> SaveDoomedAreas, so there's nothing to pass the modified parent clip to.
> 
> I apparently deleted the corresponding stanza from miValidateTree in
> ae7f71a.  I'm not sure why I didn't hit miext/rootless then too.

Because no-one loves rootless. I believe your analysis is correct; the
'exposed' region is being abused here to temporarily hold the region to
be saved. I'll bet I did that to 'optimize' region usage in the original
mi validate tree code -- 'exposed' is purely a temp variable, passed
around to avoid re-initializing a region over and over. That should be
fixed, and the leak of 'exposed' in the rootless code should be fixed as
well.

So much bad code, so little time.

Let me know how much you're willing to clean this stuff up, I'll review
whatever you manage to change.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100519/c4e5ea7e/attachment.pgp>