review requests

Jamey Sharp jamey at minilop.net
Wed May 19 11:07:58 PDT 2010


I've been submitting a lot of xserver patches lately, and I gotta say,
I'm really glad there's a review process in place. There's too much
cruft here for any one person to have a hope of predicting whether a
patch will work in all circumstances.

Reviewer bandwidth continues to be an issue though. I have two patch
series out for review, and one's three and a half weeks old now. I'd
really appreciate comments on these:

  git://people.freedesktop.org/~jamey/xserver events
  git://people.freedesktop.org/~jamey/xserver resource-errors

Their summaries are below.

Thanks!
Jamey


The following changes since commit 673eb707ce6737284c4886265ba149c5587a74e2:
  Jamey Sharp (1):
        SyncSendAlarmNotifyEvents: check the correct client's clientGone flag.

are available in the git repository at:

  git://people.freedesktop.org/~jamey/xserver events

Jamey Sharp (4):
      xv: TryClientEvents already checks client and sets sequenceNumber.
      Make WriteEventsToClient/WriteToClient no-op on fake or dead clients.
      Set event sequence number in WriteEventsToClient instead of at callers.
      Use WriteEventsToClient rather than TryClientEvents where possible.

 Xext/saver.c                          |    7 +-----
 Xext/security.c                       |   14 +++---------
 Xext/shape.c                          |    7 +-----
 Xext/shm.c                            |    1 -
 Xext/sync.c                           |   12 +---------
 Xext/xcalibrate.c                     |    4 +--
 Xext/xvdisp.c                         |    1 -
 Xext/xvmain.c                         |   34 +++++++++++---------------------
 damageext/damageext.c                 |    7 +----
 dix/dispatch.c                        |    1 -
 dix/events.c                          |   18 ++++++----------
 dix/inpututils.c                      |    1 -
 dix/selection.c                       |   12 +++++-----
 glx/glxdri2.c                         |    1 -
 hw/xfree86/dixmods/extmod/xf86vmode.c |    7 +-----
 hw/xfree86/dri2/dri2ext.c             |    5 ----
 hw/xquartz/applewm.c                  |   10 +-------
 hw/xquartz/xpr/appledri.c             |    8 +------
 hw/xwin/winwindowswm.c                |    4 +--
 mi/miexpose.c                         |    5 ++-
 os/io.c                               |    8 ++++--
 randr/rrcrtc.c                        |    1 -
 randr/rroutput.c                      |    1 -
 randr/rrproperty.c                    |    6 -----
 randr/rrscreen.c                      |    2 -
 xfixes/cursor.c                       |    4 +--
 xfixes/select.c                       |    4 +--
 xkb/xkbEvents.c                       |    1 -
 28 files changed, 51 insertions(+), 135 deletions(-)



The following changes since commit 673eb707ce6737284c4886265ba149c5587a74e2:
  Jamey Sharp (1):
        SyncSendAlarmNotifyEvents: check the correct client's clientGone flag.

are available in the git repository at:

  git://people.freedesktop.org/~jamey/xserver resource-errors

Jamey Sharp (2):
      Return an appropriately-typed error from dixLookupResourceByType.
      Add typed resource-lookup errors for non-core resource types.

 Xext/panoramiX.c                     |    4 +
 Xext/panoramiXprocs.c                |  124 +++++++++++++++++-----------------
 Xext/saver.c                         |   10 +--
 Xext/security.c                      |    5 +-
 Xext/shape.c                         |   14 ++--
 Xext/shm.c                           |    5 +-
 Xext/sync.c                          |   19 +++--
 Xext/xtest.c                         |    2 +-
 Xext/xvdisp.c                        |   24 +++---
 Xext/xvdix.h                         |    2 +-
 Xext/xvmain.c                        |    1 +
 Xext/xvmc.c                          |   15 ++--
 Xi/exevents.c                        |    4 +-
 Xi/xichangecursor.c                  |    2 +-
 Xi/xipassivegrab.c                   |    2 +-
 composite/compext.c                  |    5 +-
 damageext/damageext.c                |    3 +-
 damageext/damageextint.h             |    2 +-
 dbe/dbe.c                            |    6 +-
 dix/cursor.c                         |    4 +-
 dix/dispatch.c                       |   46 +++++++------
 dix/dixfonts.c                       |    1 -
 dix/dixutils.c                       |    8 +--
 dix/events.c                         |    8 +-
 dix/gc.c                             |    2 -
 dix/resource.c                       |  101 ++++++++++++++++++++-------
 dix/window.c                         |    8 +-
 hw/xfree86/dixmods/extmod/xf86dga2.c |    4 +-
 include/resource.h                   |    3 +
 randr/randrstr.h                     |    6 +-
 randr/rrcrtc.c                       |    3 +-
 randr/rrmode.c                       |    1 +
 randr/rroutput.c                     |    1 +
 record/record.c                      |    5 +-
 render/picture.c                     |    2 -
 render/picturestr.h                  |    2 +-
 render/render.c                      |   48 ++++++++-----
 xfixes/cursor.c                      |    9 +--
 xfixes/region.c                      |    6 +-
 xfixes/xfixes.c                      |    1 +
 xfixes/xfixes.h                      |    5 +-
 41 files changed, 293 insertions(+), 230 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100519/4160c5ff/attachment.pgp>


More information about the xorg-devel mailing list