[PATCH] dix: Remove a large pile of backing store leftovers

[Keith Packard]

On Tue, 18 May 2010 17:57:31 -0400, Adam Jackson <ajax at redhat.com> wrote:

> Since we're breaking ScreenRec, might as well break it good and hard.

Looking good to me. Should change backStorage into a boolean instead of
a pointer now too -- it's only used in compinit.c.

> diff --git a/mi/mibstore.c b/mi/mibstore.c
> index 262b494..827b9b2 100644
> --- a/mi/mibstore.c
> +++ b/mi/mibstore.c
> @@ -40,10 +40,4 @@
>  void
>  miInitializeBackingStore (ScreenPtr pScreen)
>  {
> -    pScreen->SaveDoomedAreas = NULL;
> -    pScreen->RestoreAreas = NULL;
> -    pScreen->ExposeCopy = NULL;
> -    pScreen->TranslateBackingStore = NULL;
> -    pScreen->ClearBackingStore = NULL;
> -    pScreen->DrawGuarantee = NULL;
>  }

Can we remove this function? It hasn't done anything useful for a long
time.

> diff --git a/mi/mivalidate.h b/mi/mivalidate.h
> index ef258c0..18700ac 100644
> --- a/mi/mivalidate.h
> +++ b/mi/mivalidate.h
> @@ -40,8 +40,7 @@ typedef union _Validate {
>  	DDXPointRec	oldAbsCorner;	/* old window position */
>  	RegionPtr	borderVisible;	/* visible region of border, */
>  					/* non-null when size changes */
> -	Bool		resized;	/* unclipped winSize has changed - */
> -					/* don't call SaveDoomedAreas */
> +	Bool		resized;	/* unclipped winSize has changed */

You can get rid of 'resized' here, except that rootless validate still
uses it for unknown reasons, I suspect it should be using borderVisible
!= NULL?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100518/f06863d1/attachment.pgp>