[PATCH] mi: removed the invisible cursor sprite; use NullCursor instead.

Oliver McFadden oliver.mcfadden at nokia.com
Mon May 17 23:58:45 PDT 2010


On Tue, 2010-05-18 at 08:34 +0200, ext Keith Packard wrote:
> On Tue, 18 May 2010 08:44:27 +0300, Oliver McFadden <oliver.mcfadden at nokia.com> wrote:
> 
> > I suppose for HW cursor it doesn't really matter since we wouldn't take
> > damage on that, right? We just draw everything normally, then tell the
> > HW to draw a sprite at X,Y? (Again, haven't looked at HW cursor code so
> > perhaps I'm totally off the mark.)
> 
> Right, there won't be damage, the question is whether I can remove the
> empty invisible cursor safely now, or whether drivers are all going to
> explode when presented with a NULL cursor.

Right, this is a good question. I didn't think of this.

hw/xfree86/modes/xf86Cursors.c seems to be doing NULL checking on the
cursor from my quick read-through, but whether every case is NULL
checked... I do not know.

I can look into applying the patch on my laptop and checking with the
radeonhd driver, but if someone else wants to test also please feel
free.



More information about the xorg-devel mailing list