[PATCH] mi: removed the invisible cursor sprite; use NullCursor instead.

Oliver McFadden oliver.mcfadden at nokia.com
Mon May 17 22:44:27 PDT 2010


On Mon, 2010-05-17 at 18:43 +0200, ext Keith Packard wrote:
> On Mon, 17 May 2010 07:50:25 +0300, Oliver McFadden <oliver.mcfadden at nokia.com> wrote:
> > Previously the cursor code would be called even with a "hidden" cursor.
> > This was because the X server used an invisible 1x1 cursor sprite,
> > rather than a NULL cursor.
> > 
> > This will help performance when XDefineCursor() is never called, and
> > also when the cursor is hidden via XFixesHideCursor() as there are no
> > damage events generated via the MI functions.
> > 
> > Note that this only applies for software cursors.
> 
> This comment seems confusing -- does this mean that the hardware
> cursor path will need fixing too?

I haven't looked at the HW cursor code. misprite.c is only for the SW
cursor (as far as I know.)

I suppose for HW cursor it doesn't really matter since we wouldn't take
damage on that, right? We just draw everything normally, then tell the
HW to draw a sprite at X,Y? (Again, haven't looked at HW cursor code so
perhaps I'm totally off the mark.)



More information about the xorg-devel mailing list