[PATCH v3] xfree86: Add option parsing for percent options.

Dan Nicholson dbn.lists at gmail.com
Mon May 17 19:28:17 PDT 2010


On Mon, May 17, 2010 at 6:12 PM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> In some cases, an option of "50%" would be preferable over fixed value
> configuration - especially if the actual values are autoprobed.
> Add a new set of functions to parse percent values from configurations.
>
> The percent value parsing differs slightly - if the option is not to marked
> as used (e.g. xf86CheckPercentOption()), no warning is emitted to the log
> file if the value is not a percent value. This allows double-options (either
> as % or as absolute number) without warnings.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>
> Changes to v2:
> - xwin pieces added (untested). John, Yaakov, can you please give this a
>  quick test?
> - optionTypeToString missing bits added
> - DESIGN.sgml updated to list the new option

Looks pretty good to me, although I didn't really review the xwin parts.

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>


More information about the xorg-devel mailing list