[PATCH] Device init: Don't crash when CreateGC fails.

Jeremy Huddleston jeremyhu at apple.com
Fri May 14 14:15:21 PDT 2010


On May 14, 2010, at 12:47, Jamey Sharp wrote:

> On Fri, May 14, 2010 at 12:40 PM, Jeremy Huddleston <jeremyhu at apple.com> wrote:
>> Thanks Jamey!
>> 
>> Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
> 
> No problem! Out of curiousity, did you just review the patch, or also
> test it? I'd be inclined to add a tested-by line as well for you if
> you did, in fact, test. :-)
> 
> Also I'm really hoping Peter or somebody else who knows the input bits
> will review this before it's merged. I'm confident it fixes the
> symptom, and I'm pretty sure the patch isn't outright wrong, but there
> might be something better to do?

I didn't, but I did just now and got the expected.

Fatal server error:
Failed to activate core devices.
   OsVendorFatalError
   AbortDDX

Tested-by: Jeremy Huddleston <jeremyhu at apple.com>



More information about the xorg-devel mailing list