[PATCH] dri2: Send out event when auxillary buffers are invalidated

Keith Packard keithp at keithp.com
Fri May 14 12:25:19 PDT 2010


On Fri, 14 May 2010 10:14:29 -0700, Dan Nicholson <dbn.lists at gmail.com> wrote:

> It seems like there could be more than one person looking at a pull
> request, checking the review status of the patches, judging if there
> isn't anything inherently wrong with the patchset, and seeing if they
> merge properly.

I think I should be communicating more clearly what I think the status
of each patch set is. Kristian's recent DRI2 event patches pended for a
day with both of us waiting, I was waiting to hear him answer Adam's
question and he was waiting to see me merge things in. I could easily
have replied to Adam's message asking Kristian for an answer explicitly.

What is clearly needed is some indication after each reply from a
reviewer as to whether the patch is ready for merging. Right now, it's
all implicit - a patch which is reviewed is supposed to be ready for
merging, and yet if the review wasn't cc'd to me, or if there are
questions along with the review, then I'm left wondering what's going
on.

What I will do for now is send a message when I'm waiting for additional
information about a patch or pull request. That's easy enough for me to
do when pulling items out of my incoming queue. In addition, I'll mark
patches which aren't ready for merging as 'pending' so that I can check
up on them after a day of inaction.

I'd also be interested to hear how coordination between multiple master
mergers would work; it seems like it would be difficult to avoid a
fairly massive duplication of effort.

On that note -- I'm on vacation May 26-31 and will be out of reach of
networks much of that time. Would someone like to do  merging during
that time?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100514/5055f692/attachment.pgp>


More information about the xorg-devel mailing list