[PATCH input-keyboard 02/13] Missing #ifdef for PCCONS

[Dan Nicholson]

On Fri, May 14, 2010 at 10:35 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
> On Fri, 2010-05-14 at 06:35 -0700, Dan Nicholson wrote:
>
> On Wed, May 12, 2010 at 10:11 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
>> Compiling this BSD file under Linux finds errors in conditional code.
>> PCCONS is undefined and should be protected with PCCONS_SUPPORT
>
> Why would the bsd sources get compiled on linux?
>
> To simulate a bsd system that does not have PCCONS support.
>
> In xserver config at line 426,
>
>   *openbsd*)
> 	AC_DEFINE(CSRG_BASED, 1, [System is BSD-like])
> 	AC_DEFINE(PCVT_SUPPORT, 1, [System has PC console])
> 	AC_DEFINE(WSCONS_SUPPORT, 1, [System has wscons console])
> 	;;
>
> there is no PCCONS_SUPPORT. I don't have a running openbsd system, I can
> only guess what the situation can be at the moment:
>
> 1- If openbsd does in fact not support PCCONS, the code fails to compile
> 2- If openbsd does in fact support PCCONS and xserver fails to set
> PCCONS_SUPPORT, a new fix is required.
>
> Any insight into this is welcome. I'll update the commit msg.

Yes. "Don't compile code depending on PC console when it's not
supported" makes more sense.

--
Dan