[PATCH input-keyboard 02/13] Missing #ifdef for PCCONS

Dan Nicholson dbn.lists at gmail.com
Fri May 14 06:35:51 PDT 2010


On Wed, May 12, 2010 at 10:11 AM, Gaetan Nadon <memsize at videotron.ca> wrote:
> Compiling this BSD file under Linux finds errors in conditional code.
> PCCONS is undefined and should be protected with PCCONS_SUPPORT

Why would the bsd sources get compiled on linux?

>
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
>  src/bsd_kbd.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/src/bsd_kbd.c b/src/bsd_kbd.c
> index bc80692..8575ab2 100644
> --- a/src/bsd_kbd.c
> +++ b/src/bsd_kbd.c
> @@ -88,8 +88,10 @@ SetKbdLeds(InputInfoPtr pInfo, int leds)
>
>     switch (pKbd->consType) {
>
> +#if defined (PCCONS_SUPPORT)

This and the others can use the simpler "#ifdef PCCONS_SUPPORT" like
later in SoundBell.

--
Dan


More information about the xorg-devel mailing list