[PATCH] dri2: Send out event when auxillary buffers are invalidated

Kristian Høgsberg krh at bitplanet.net
Thu May 13 04:23:55 PDT 2010


Keith, are you waiting for more reviews on this one?  We already
discussed the basic idea at great length prior to the 1.8 release and
it got bumped only because it was a new feature too close to the
release date.  I've update the functionality to use the client
tracking we put in place for the DRI2 resource fix, but other than
that the idea is the same.

It would be nice if you could reply to a patch early on with what the
status is, like "need more reviews", "looks good, will apply next time
I do patches" or such.  Right now I don't know if a patch got lost, if
you're not happy with it or just waiting for reviews.  If you want to
be "Linus of the X server", I think you need to spend more time doing
patches than you're doing now.  As it is, I'm not exactly encouraged
to work on the X server.

Kristian

2010/5/11 Adam Jackson <ajax at nwnk.net>:
> On Tue, 2010-05-11 at 12:15 -0400, Kristian Høgsberg wrote:
>> 2010/5/11 Adam Jackson <ajax at nwnk.net>:
>> > Is ConfigNotify sufficient for this?  I think it'll miss subwindows.
>> > The ConfigNotify chain looks like it only fires from ConfigureWindow(),
>> > which is not itself recursive to children.  I think you may want
>> > ResizeWindow instead.
>>
>> What do you want to do for subwindows?  It doesn't matter if they get
>> resized, we only care about the size of the DRI2 window, which is what
>> determines the size of the aux buffers.
>
> Ah, got it.  You don't care about being clipped to parent for DRI2
> subwindows, because your buffers are always full-sized.  My brain is
> still damaged by DRI1.
>
> Given that,
>
> Reviewed-by: Adam Jackson <ajax at redhat.com>
>
> - ajax
>


More information about the xorg-devel mailing list