[PATCH 3/5] Do not jump through the hoops to deallocate xkbbasedirflag variable

Mikhail Gusarov dottedmag at dottedmag.net
Wed May 12 14:26:08 PDT 2010


Twas brillig at 14:04:13 12.05.2010 UTC-07 when jamey at minilop.net did gyre and gimble:

 >> -    const char *emptystring = "";
 >> -    const char *xkbbasedirflag = emptystring;
 >> +    char *emptystring = "";
 >> +    char *xkbbasedirflag = NULL;
 >>     const char *xkbbindir = emptystring;
 >>     const char *xkbbindirsep = emptystring;

 JS> It looks like you didn't need to change the declaration of
 JS> emptystring. I'd vote for keeping that const, since string literals
 JS> really aren't writable.

Yep, it is an accidental change. Will fix.

-- 
  http://fossarchy.blogspot.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100513/83d4d929/attachment.pgp>


More information about the xorg-devel mailing list